Fix delayed game switch #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous check was unreliable, it's still possible we were called from user code when it's disabled (launch from SD will disable to flash).
Daft-Freak
force-pushed
the
game-switch-fix
branch
from
999c20c
to
b1973b2
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous check was unreliable, it's still possible we were called from user code when it's disabled (launch from SD will disable user code to flash before calling this).
Replace the check with a bool set around calling tick, which should always be accurate. (Unless someone attempts to launch from
render...)This reliably crashed my blithub downloader, but doesn't seem to break the launcher even though it should...