Minor firmware blit flashing improvements #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Results in the bar disappearing if you attempt to save a ~14MB+ file
We don't get any info about why it failed... so it's not the most helpful message
We have all the info here
If we don't we might write some extra data at the end of the file... But it will get overridden when the next game is flashed. (The scanning code uses the length in the header.)
~700 bytes less code than the 64bit divide
|
I should probably prep a release at some point to sweep up all these changes! Thank you, and sorry for the continued lack of attention here- I think burnout is slowly grinding me down 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First half: fixes some issues with failed flashes. Second half: use file size from headers instead of the actual file size.
A side effect of this is that you can append extra data to the end of a .blit and the flashing code ignores it (at least when loading from the SD card). Previously it would get flashed, but would likely get another .blit flashed on top of it later.