Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Make emscripten path warning more obvious. #793

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

Gadgetoid
Copy link
Contributor

This bit me when I was testing #792 - hopefully splitting the configure and build steps, and decorating the step with a ⚠️ will make it more obvious.

@Daft-Freak
Copy link
Collaborator

Looks more obvious to me.

(I wonder if enough time has passed that we can recommend cmake -B build instead of the mkdir/cd dance 🤔. That's probably for another PR though.)


:warning: Make sure to include the `-D32BLIT_DIR="/path/to/32blit/repo"` parameter to the `cmake` command (even when building the SDK examples). You must specify an absolute path here when building with Emscripten.

Once cmake has finished configuring your project you can build it:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"CMake" here I think

@ahnlak
Copy link
Contributor

ahnlak commented Feb 11, 2023

I know the Emscripten docs tell you to use emmake make rather than a naked make, although functionally it ends up the same (I assume?)

Also, isn't it more 'Emscripten-y' to use emrun instead of doing the python web thingie by hand?

@Daft-Freak
Copy link
Collaborator

Not using emmake usually works if you don't depend on environment variables at build time. (CMake's makefiles hardcode pretty much everything).

Using emrun would probably be a good idea, at least so stuff doesn't break if security gets more strict again (it sets all the magic headers so that things like threads work). Does have the disadvantage that you have to specify an example though.

@Gadgetoid Gadgetoid merged commit 9adbf2e into master Feb 21, 2023
@Daft-Freak Daft-Freak deleted the patch-emscripten-readme branch February 22, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants