Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix builds using pico.toochain with SDK 1.5.0 #797

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

Daft-Freak
Copy link
Collaborator

The blit SDK itself is not affected by this as it includes the pico-sdk import in the root CMakeLists. Anything using the toolchain file (like the boilerplate) is a bit broken.

Prevents errors like:

[cmake] CMake Error at /home/daftfreak/workspace/pico/pico-sdk/tools/CMakeLists.txt:61 (find_package):
[cmake]   find_package called with invalid argument ".."
[cmake] Call Stack (most recent call first):
[cmake]   /home/daftfreak/workspace/pico/pico-sdk/src/rp2_common.cmake:47 (pico_add_uf2_output)
[cmake]   32blit-pico/CMakeLists.txt:140 (pico_add_extra_outputs)
[cmake]   32blit-pico/CMakeLists.txt:148 (blit_executable_int_flash)

The blit SDK itself is not affected by this as it includes the pico-sdk import in the root CMakeLists. Anything using the toolchain file (like the boilerplate) is.
@Gadgetoid Gadgetoid merged commit 52e87e6 into master Feb 23, 2023
@Gadgetoid
Copy link
Contributor

Ooof! Did your autobuildamajig catch these?

@Daft-Freak Daft-Freak deleted the patch-fix-pico-toolchain branch February 23, 2023 10:40
@Daft-Freak
Copy link
Collaborator Author

Sort-of. I tagged a release on rocks-and-diamonds to fix an issue the auto-builder was having... and the PicoSystem action failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants