CI: Upload install results as artifacts. #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gadgetoid
force-pushed
the
ci/artifacts
branch
4 times, most recently
from
23c1b16
to
d59c8b7
Compare
Gadgetoid
force-pushed
the
ci/artifacts
branch
from
d59c8b7
to
3260343
Compare
|
Ah, using install instead of package to avoid the "double zip" problem. |
|
Hahaha 🤣 yeah that particular nonsense irritates me far more than it should. Enough that I’d waste way too much time working around it. |
|
Just noticed a problem here: MinGW/macOS don't do releases, so don't have a "release-suffix" set... which results in them generating a combined artifact. ... and as those are the largest two builds, it's quite big...
|
|
Okay, the size is mostly macOS... also takes nearly four minutes to upload its huge artifact. (I guess it's a combination of the fat x86+arm binaries and every bundle including the SDL framework) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I instinctively went for the artifacts to try and test some changes on a PR and found there were none 😢
This PR should fix that!