Update CubeMX project clocks to match final hardware #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Final hardware uses a 12MHz crystal on HSE and the PLL dividers are found in main.c.
|
Just noticed that there is another one of these in 32blit-hardware repo. |
|
This one is my fault: #558, wouldn't be surprised if there's more code that's out-of-sync with the .ioc though. |
|
I checked all the pin assignments and they look okay. I did a PR against the hardware repo. Maybe we should get rid of the copy here? |
|
Might be sensible to drop the copy here, though now you've corrected it (Thanks, STM32Cube is freakin' awful) it wont ever change again, so it's not like we'll have to keep them in sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final hardware uses a 12MHz crystal on HSE and the PLL dividers are found in main.c.