SDL screen mode/size improvements #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes some warnings about x/y not being initialised and simplifies the code a bit.
stm32 and pico are already doing this.
WE only need the size now
screen-mode test now looks as nice as it does on hardware. (+anything running in BlitSim)
Would end up crashing with surface height > 255. Removing the cast is slightly less code on arm anyway
|
Oops, included #824. My preferred solution is to merge that though, bit hard to build things here without it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncs SDL screen mode handling with the other ports and allows overriding the screen size on the command line. (Can finally test picosystem things in SDL without hacking the sources)
Also fixes a bug with surfaces taller than 255. (I tried 240x320 for fun).
(I definitely did this because of the picosystem thing and not because of blitsim.)