More pico config #827
Merged
More pico config #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of definitions on the command line was getting silly
To hopefully avoid more code relying on internal #defines to guess the board type... (DISPLAY_ST7789 != PicoSystem)
One less use of the DISPLAY_ #defines
|
Okay, tested the vga board hires change on pico dv (it does the same thing)... after spending way too much time getting that to work again. |
Daft-Freak
added a commit
that referenced
this pull request
Aug 29, 2023
Otherwise the LED is never going to get enabled (broken by #827)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pin config for ST7789 displays and moves some of the definitions to a board-specific config.h instead of specifying all of them on the command line.
This is before I add more defines for SD card config... (Which isn't here, as SD card support is in another PR)
I've only tested this on PicoSystem, as I don't currently have the display packs or a monitor for my VGA board.