Add Surface::get_pixel and remove special case from blit code #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…step This is a few ms faster in tilemap-test on PicoSystem/Vision (and a _tiny_ bit faster on stm32) and should allow removing all the step==0 special cases in the blend code
Same logic should apply as TileMap, haven't checked perf yet
Nothing does this any more
|
Wow, I can't even wrap my brain around what the edge case was doing and why, but it was... janky 😬 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After repeating my "blit that is actually a fill" optimisation for the third time, I worked out a way to avoid it entirely and improve TileMap perf a bit. Also adds a useful
get_pixelmethod toSurface(returns the pixel converted to aPen).I haven't benchmarked the change to
stretch_blit, but I'd expect a similar effect there.(Making the blit code smaller is also a good thing for the firmware)