Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VERBATIM to CMake custom commands #835

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

Daft-Freak
Copy link
Collaborator

Someone thought using a build dir with () in it was a good idea, resulting in a lot of

/bin/sh: -c: line 1: syntax error near unexpected token `('

Adding this magic flag allows them to continue making poor choices fixes that problem.

Also the CMake docs say that this is a good idea:

 Use of VERBATIM is recommended as it enables correct behavior.

Avoids shell errors when the build dir contains certain characters. The CMake docs also recommend doing this.
@Gadgetoid
Copy link
Contributor

Urge to look up why this isn't the default 😆 sheesh!

Thank you!

@Gadgetoid Gadgetoid merged commit 7048b93 into 32blit:master Sep 6, 2023
8 checks passed
@Daft-Freak Daft-Freak deleted the escape-more branch September 6, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants