Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework TMX struct #79

Merged
merged 4 commits into from
May 26, 2021
Merged

Rework TMX struct #79

merged 4 commits into from
May 26, 2021

Conversation

Daft-Freak
Copy link
Collaborator

This is the more-breaky (but also fixes more) alternative to #76
Requires 32blit/[email protected]:tiled-new-struct

From the comment there:

* Fixes `empty_tile` for 16 bit

* Adds `flags` so that 16 bit/transforms can be detected

* Only include the transforms with the struct if any are non-zero (always include for the "raw" output)

* More validation for `load_tmx`

* Adds a length field so that any future changes can be less breaky

* Happens to make the struct a nice round 16 bytes... (and fixes the alignment)

* Breaks the TMX struct

* Guess it should be using construct...

@coveralls
Copy link

Pull Request Test Coverage Report for Build 741392978

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 72.793%

Files with Coverage Reduction New Missed Lines %
ttblit/asset/builders/map.py 1 97.92%
Totals Coverage Status
Change from base Build 664499501: 0.1%
Covered Lines: 907
Relevant Lines: 1246

💛 - Coveralls

@Gadgetoid Gadgetoid merged commit 8f520e7 into 32blit:master May 26, 2021
@Gadgetoid
Copy link
Contributor

Time to explode Super Square Bros. Thank you 😆

Heads up @ThePythonator

@Daft-Freak Daft-Freak deleted the tiled-new-struct branch May 26, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants