Merge remote-tracking branch 'upstream/master'

# Conflicts:
#	test/spec/modules/33acrossBidAdapter_spec.js

.circleci/config.yml

@@ -33,7 +33,7 @@ jobs:
             - node_modules
           key: v1-dependencies-{{ checksum "package.json" }}
 
-      - run: sudo npm install -g gulp
+      - run: sudo npm install -g gulp-cli
       # Download and run BrowserStack local
       - run:
           name : Download BrowserStack Local binary and start it.

.eslintrc.js

@@ -26,7 +26,6 @@ module.exports = {
     // Violations of these styles should be fixed, and the exceptions removed over time.
     //
     // See Issue #1111.
-    "camelcase": "off",
     "eqeqeq": "off",
     "no-return-assign": "off",
     "no-throw-literal": "off",

PR_REVIEW.md

@@ -18,6 +18,7 @@ For modules and core platform updates, the initial reviewer should request an ad
 - Once there is 2 `LGTM` on the PR, merge to master
 - Ask the submitter to add a PR for documentation if applicable.
 - Add a line into the [draft release](https://github.com/prebid/Prebid.js/releases) notes for this submission. If no draft release is available, create one using [this template]( https://gist.github.com/mkendall07/c3af6f4691bed8a46738b3675cb5a479)
+- Add the PR to the appropriate project board (I.E. 1.23.0 Release) for the week, [see](https://github.com/prebid/Prebid.js/projects)
 
 ### New Adapter or updates to adapter process
 - Follow steps above for general review process. In addition, please verify the following:
@@ -39,9 +40,9 @@ For modules and core platform updates, the initial reviewer should request an ad
 ## Ticket Coordinator
 
 Each week, Prebid Org assigns one person to keep an eye on incoming issues and PRs. That person should:
-- Review issues and PRs at least once per weekday for new items.
+- Review issues and PRs at least once per weekday for new items. Encourage a 48 "SLA" on PRs/issues assigned. Aim for touchpoint once every 48/hours. 
 - For PRs: assign PRs to individuals on the PR review list. Try to be equitable -- not all PRs are created equally. Use the "Assigned" field and add the "Needs Review" label.
-- For Issues: try to address questions and troubleshooting requests on your own, assigning them to others as needed.
+- For Issues: try to address questions and troubleshooting requests on your own, assigning them to others as needed. Please add labels as appropriate (I.E. bug, question, backlog etc).
 - Issues that are questions or troubleshooting requests may be closed if the originator doesn't respond within a week to requests for confirmation or details.
 - Issues that are bug reports should be left open and assigned to someone in PR rotation to confirm or deny the bug status.
 - It's polite to check with others before assigning them large tasks.

README.md

@@ -4,6 +4,7 @@
 [![Code Climate](https://codeclimate.com/github/prebid/Prebid.js/badges/gpa.svg)](https://codeclimate.com/github/prebid/Prebid.js)
 [![Coverage Status](https://coveralls.io/repos/github/prebid/Prebid.js/badge.svg)](https://coveralls.io/github/prebid/Prebid.js)
 [![devDependencies Status](https://david-dm.org/prebid/Prebid.js/dev-status.svg)](https://david-dm.org/prebid/Prebid.js?type=dev)
+[![Total Alerts](https://img.shields.io/lgtm/alerts/g/prebid/Prebid.js.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/prebid/Prebid.js/alerts/)
 
 # Prebid.js
 
@@ -29,6 +30,8 @@ Working examples can be found in [the developer docs](http://prebid.org/dev-docs
     $ npm install
 
 *Note:* You need to have `NodeJS` 4.x or greater installed.
+*Note:* Because we have transitioned to using gulp 4.0 - you need to have `gulp-cli` installed globally prior to running the general `npm install`.  Run the following command to perform the install: `npm install gulp-cli -g`
+If you have a previous version of `gulp` installed globally, you'll need to remove it before installing `gulp-cli`.  This removal can be done with the command: `npm rm gulp -g`
 
 <a name="Build"></a>
 

RELEASE_SCHEDULE.md

@@ -17,13 +17,17 @@ Announcements regarding releases will be made to the #headerbidding-dev channel
 
 ## Release Process
 
-1. Make Sure all browserstack tests are passing. On PR merge to master travis will run unit tests on browserstack. Checking the last travis build [here](https://travis-ci.org/prebid/Prebid.js/branches) for master branch will show you detailed results. 
+_Note: If `github.com/prebid/Prebid.js` is not configured as the git origin for your repo, all of the following git commands will have to be modified to reference the proper remote (e.g. `upstream`)_
+
+1. Make Sure all browserstack tests are passing. On PR merge to master CircleCI will run unit tests on browserstack. Checking the last CircleCI build [here](https://circleci.com/gh/prebid) for master branch will show you detailed results. 
 
    In case of failure do following, 
      - Try to fix the failing tests.
      - If you are not able to fix tests in time. Skip the test, create issue and tag contributor.
 
    #### How to run tests in browserstack
+
+   _Note: the following browserstack information is only relevant for debugging purposes, if you will not be debugging then it can be skipped._
 
    Set the environment variables. You may want to add these to your `~/.bashrc` for convenience.
 
@@ -59,11 +63,12 @@ Announcements regarding releases will be made to the #headerbidding-dev channel
    Pull these changes locally by running command 
    ```
    git pull
+   git fetch --tags
    ``` 
 
    and verify the tag.
 
-5. Update coveralls
+5. Update coveralls _(skip for legacy)_
 
    We use https://coveralls.io/ to show parts of code covered by unit tests.
 
@@ -75,22 +80,35 @@ Announcements regarding releases will be made to the #headerbidding-dev channel
 
    Run `gulp coveralls` to update code coverage history.
 
-6. Distribute the code
+6. Distribute the code 
+
+   _Note: do not go to step 7 until step 6 has been verified completed._
 
    Reach out to any of the Appnexus folks to trigger the jenkins job.
 
    // TODO 
    Jenkins job is moving files to appnexus cdn, pushing prebid.js to npm, purging cache and sending notification to slack.
    Move all the files from Appnexus CDN to jsDelivr and create bash script to do above tasks.
 
-7. Post Release Steps
+7. Post Release Version
 
    Update the version
    Manually edit Prebid's package.json to become "1.x.x-pre" (using the values for the next release). Then commit your changes.
    ```
    git commit -m "Increment pre version"
    git push
    ```
+
+8. Create new release draft
+
+   Go to [github releases](https://github.com/prebid/Prebid.js/releases) and add a new draft for the next version of Prebid.js with the following template:
+```
+## 🚀New Features
+ 
+## 🛠Maintenance
+ 
+## 🐛Bug Fixes
+```
 
 ## Beta Releases
 

governance.md

@@ -2,10 +2,10 @@
 
 This document describes the governance model for the Prebid project. The Prebid project’s stated mission is to facilitate fair, transparent, and effective header bidding across the industry, and is responsible for creating and maintaining such projects as [Prebid.js](https://github.com/prebid/Prebid.js).
 
-1.	A single Tech Lead oversees the technical direction of the project and appoints Core Team members
+1.	A single Tech Lead (PMC Chair) oversees the technical direction of the project and appoints Core Team members
 2.	The Core Team members maintain the project on an ongoing basis with direction from the Tech Lead.
 3.	In the event of any disagreements, the Tech Lead will make a final decision.
-4.	If there is no Tech Lead available to perform his/her duties, AppNexus Inc. will appoint one.
+4.	If there is no Tech Lead available to perform his/her duties, Prebid.org will appoint one.
 
 ### Roles and Responsibilities:
 - **User:** Any individual who consumes / uses the Prebid.js library.
@@ -15,9 +15,9 @@ This document describes the governance model for the Prebid project. The Prebid
 
 ### Current Prebid.js Core Team
 - @mkendall07 (Tech Lead)
-- @protonate
+- @jsnellbaker
 - @matthewlane
 - @jaiminpanchal27
 - @snapwich
 - @harpere
-- @dbemiller
+- @mike-chowla