[APPROVED]: Refactoring - break functions that are handling multiple storage types. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosfelix
force-pushed
the
user_id_refactoring
branch
from
3638b10
to
09c746d
Compare
macinjosh32
reviewed
May 7, 2024
modules/userId/index.js
Outdated
| @@ -319,15 +352,7 @@ function getStoredValue(submodule, key = undefined) { | |||
| if (storage.type === COOKIE) { | |||
| storedValue = mgr.getCookie(storedKey); | |||
There was a problem hiding this comment.
Optional: Even though it's just one line, it might be a good idea to extract the mgr.getCookie(storedKey) into a function getValueFromCookie in order to keep the abstraction level consistent. It could make further refactoring opportunities more apparent later on.
macinjosh32
changed the title
carlosfelix
force-pushed
the
user_id_refactoring
branch
from
09c746d
to
4ecda49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.