Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code quality control actions #2

Open
1 of 3 tasks
rldhont opened this issue Jan 18, 2021 · 5 comments
Open
1 of 3 tasks

Add code quality control actions #2

rldhont opened this issue Jan 18, 2021 · 5 comments

Comments

@rldhont
Copy link

rldhont commented Jan 18, 2021 •
edited by Gustry
Loading

As for lizmap-web-client, add the actions:

  • php-cs-fixer
  • phpstan
  • eslint
@Gustry
Copy link
Member

Gustry commented Jan 19, 2021

As it's pretty similar, I would also add this github action :
https://github.com/3liz/lizmap-pgmetadata-module/blob/main/.github/workflows/release.yml
(same request in other tickets created by @rldhont )

This was referenced Jan 20, 2021
Closed
Closed
Merged
@pdrillin
Copy link
Contributor

@rldhont it's an api so this module don't need eslint because he haven't js file

@rldhont
Copy link
Author

rldhont commented Jan 21, 2021

@drillinP ok, I update the description.

@Gustry
Copy link
Member

Gustry commented Apr 26, 2021

#7 merged but I have disabled the action for now. Sorry. We need a proper environment to run the analysis.

@mdouchin
Copy link
Contributor

mdouchin commented Nov 2, 2022

up, no sure the recent changes have improved it or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding PhpStan and php-cs-fixer as Github actions pdrillin/lizmap-gobs-module
4 participants
@rldhont @Gustry @mdouchin @pdrillin