Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding PhpStan and php-cs-fixer as Github actions #5

Closed
wants to merge 2 commits into from
Closed

Adding PhpStan and php-cs-fixer as Github actions #5

wants to merge 2 commits into from

Conversation

pdrillin
Copy link
Contributor

@pdrillin pdrillin commented Jan 20, 2021 •
edited
Loading

@Gustry
Copy link
Member

Gustry commented Jan 20, 2021

You are missing the makefile commands to apply php-cs-fixer.
I think you can do a separate PR for php cs fixer and apply as well the update of the PHP code.

For PHPStan,
https://github.com/drillinP/lizmap-gobs-module/runs/1734230851

@pdrillin
Copy link
Contributor Author

@Gustry the commands are already in the makefile ?

@Gustry
Copy link
Member

Gustry commented Jan 21, 2021

Yes, you could look in LWC (same as for pgmetadata module, already there)

@pdrillin pdrillin closed this Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gustry Gustry Awaiting requested review from Gustry

@mdouchin mdouchin Awaiting requested review from mdouchin

@rldhont rldhont Awaiting requested review from rldhont

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add code quality control actions
2 participants
@pdrillin @Gustry