init FormControlProperty only if exists

3liz · Dec 14, 2023 · fa4faae · fa4faae
1 parent c12c1c0
commit fa4faae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/lizmap/modules/lizmap/lib/Form/QgisForm.php b/lizmap/modules/lizmap/lib/Form/QgisForm.php
@@ -1356,7 +1356,9 @@ private function fillControlFromValueRelationLayer($fieldName, $formControl)
         // if ($this->ctrl->emptyItemLabel !== null || !$this->ctrl->required)
         // To add an empty value to ValueRelation displayed as menulist, we only
         // have to set an emptyItemLabel !== null
-        $formControl->ctrl->emptyItemLabel = '';
+        if (property_exists($formControl->ctrl, 'emptyItemLabel')) {
+            $formControl->ctrl->emptyItemLabel = '';
+        }
 
         // Create Datasource
         $dataSource = new QgisFormValueRelationDynamicDatasource($formControl->ref);

diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -412,11 +412,6 @@ parameters:
 			count: 2
 			path: lizmap/modules/lizmap/lib/Form/QgisForm.php
 
-		-
-			message: "#^Access to an undefined property jFormsControl\\:\\:\\$emptyItemLabel\\.$#"
-			count: 1
-			path: lizmap/modules/lizmap/lib/Form/QgisForm.php
-
 		-
 			message: "#^Access to an undefined property jICoordPlugin\\:\\:\\$config\\.$#"
 			count: 2