Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique values indicate wrong column values #1193

Closed
remigods opened this issue Apr 11, 2019 · 8 comments
Closed

Unique values indicate wrong column values #1193

remigods opened this issue Apr 11, 2019 · 8 comments
Assignees
@rldhont @nboisteault
Labels
bug data editor
Milestone
3.2.3

Comments

@remigods
Copy link

remigods commented Apr 11, 2019 •
edited by nboisteault
Loading

When setting the field as Unique values, Lizmap in edition mode indicate, or not, the values from the right field. Within the same project, one table may display values from the same unique field for all the fields set as Unique values too.

Ex : table A, field 1 (values a, b, c), field 2 (values d, e), field 3 (f), all set as Unique values in QGIS (2.18.18). In Lizmap, field 1 should display values a, b, c, field 2 values d, e, and field 3 value f.
Here, whatever the field to be filled, only d and e values are suggested...
table B (from the same QGIS project) : Unique values set for different fields work perfectly under Lizmap.

  • Lizmap version: release_3_2
  • QGIS Server version: 2.18.28
  • QGIS Project version: 2.18.18
  • OS : Windows
  • Browser : Firefox
  • tables stored into PostgreSQL

Thanks in advance,
Rémi
@rldhont
Copy link
Collaborator

rldhont commented Apr 11, 2019

What is the primary key type in table A and table B ?

@remigods
Copy link
Author

Thanks from contributing to this issue.
table A and table B have both a gid primary key (nextval)

@nboisteault nboisteault self-assigned this Apr 12, 2019
@nboisteault
Copy link
Member

@rldhont https://github.com/3liz/lizmap-web-client/blob/release_3_2/lizmap/www/js/edition.js#L1011
When there are multiple autocomplete, selectAutocomplete has the last value set in it for every autocomplete.

@rldhont
Copy link
Collaborator

rldhont commented Apr 12, 2019

@nboisteault thanks for the review. I know how to fix it.

@rldhont rldhont added this to the 3.2.3 milestone Apr 12, 2019
@nboisteault
Copy link
Member

@rldhont Good. I was testing this answer, it is good to initiate the good values but autocomplete doesn't show filtered values.

@remigods
Copy link
Author

Thanks for your help. Should I understand it will be fixed in the next Lizmap version?
Meanwhile, I limited the Unique values to one field per layer, so that the field suggests the proper values.
I am a newcomer in GitHub. Should I close this issue?

@nboisteault
Copy link
Member

@remigods No we'll close the issue when it will be fixed (soon I think). Thanks for your issue report !

@rldhont rldhont mentioned this issue Apr 16, 2019
Merged
@rldhont
Copy link
Collaborator

rldhont commented Apr 16, 2019

Fixed needs to be tested

rldhont added a commit that referenced this issue Apr 25, 2019
@rldhont
Version 3.2.3 - bugfix release
a468a95 
Bugfix:
* Edition - Set a timeout to messages
* Dataviz - fix reference of public function resizePlot
* Dataviz - Allow to give number > 9 in template, e.g. 2
* qgisVectorLayer - try better to get table from layer datasource
* Fix edition when featureId contains multiple id
* Remove annoying logs about libspatialite.so
* Fix getWfsFeature: qgis 2.18 expects list of pk fields separated by @@
* edition: take care about potential separator @@ in featureIdParam
* Child objets in popup with QGIS server 3. #1024
* Set WFS version to 1.0.0 as default
* attribute table - non spatial children tables (display info panel) #1103
* qgisVectorLayer: avoid notices when geometry type is only 'geometry'
* LizmapWFSRequest: log failed sql only as a notice
* Media - Ensure js files are sent with correct MIME type
* WFS request - PostgreSQL: deduplicate the list of fields to avoid errors
* Incorrect title for media link #1040
* Popup - remove filter and filtertoken when needed
* Fix qgisform::saveToDb(): process uploaded file without filtering its value like a normal value
* Fix support of non required values in qgisform
* Clean name to get children popups
* Print with QGIS Server 3.0
* Popups - allways remained active and minidock dimensions #1068
* Minidock popup with wrong dimensions #1065
* edition tool - create feature = false #1071
* selection tool - special (accentuated) characters
* Fix bug WFS layers not in attribute table
* Remove exclamation mark from error messages. #979
* WMS service: inject more template variables into templates
* Fix getLayerFeature signature on lizmap object
* Fix process of the alias parameter to qgisFormControl
* Remove atlas compositions from print template selector
* attributeLayerContentReady event is called too early (attribute table is not ready) in attributeTable.js #997
* The print icon disappears in QGIS 3. #1100
* Set default value for QGIS Unique Values edition widget
* WFS GetFeature directly from Postgres : do not build request if all fields are not from table
* Fixed bad statements in qgisFormControl
* Fix uploaded file rename
* Fix QgisForm upload: no rename of the file if it has the same name of the previous one
* attribute table - media and url links
* Layerswitcher : Hide also children when parent group is hidden
* Better display of top menu bar on mobile
* Display informations only on left click
* Fix change layer style #1159
* CSS - Images: use exif data to display correct orientation
* Default style is defined as an empty string in standard and QGIS 3 #1119
* Add local JS for date picker form widget
* Use relativeWMSPath for all service requests if given
* Update some date format
* Replace date.js by moment.js #593
* More compact print UI #1151
* Unique values indicate wrong column values #1193
* Edition: Add color widget
* Fix GetFeature: delete temp file after sending it to the browser #1185
* Fix lizmapWFSRequest: avoid to use the same temp filename for all feature #1185
* Edition: For update, do not update primary keys
* Edition: Do not quote numbers for where clause

Bugfixes from release 3.1.19

Jelix version 1.6.23

Locales updated:
* Czech
* Finnish
* Italian
* Spanish
* Galician
* Hungarian
* Dutch
* Polish
* Portuguese
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rldhont rldhont

@nboisteault nboisteault

Labels
bug data editor
Projects
None yet
Milestone
3.2.3
Development

No branches or pull requests
3 participants
@rldhont @nboisteault @remigods