Tests - Add E2E test about user defined JavaScript warning #4784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gustry
added
run end2end
Gustry
force-pushed
the
javascript-test
branch
2 times, most recently
from
e39c5ed
to
d4fbb27
Compare
Gustry
force-pushed
the
javascript-test
branch
from
4e92b7c
to
82450c3
Compare
Gustry
force-pushed
the
javascript-test
branch
2 times, most recently
from
e3ecaa7
to
efd5bac
Compare
|
@nworr I have displayed the developer hint only if no additionnal JS were loaded. Maybe it would have been better with checking the flag ? Still not 100% convinced, but I think it's a small hint to display. @mdouchin ? But I don't know, the E2E is failing on CI, not on local. |
Gustry
force-pushed
the
javascript-test
branch
2 times, most recently
from
0670acf
to
6f0e9b2
Compare
Gustry
force-pushed
the
javascript-test
branch
2 times, most recently
from
a22bb8b
to
6488402
Compare
mdouchin
approved these changes
Sep 30, 2024
Gustry
force-pushed
the
javascript-test
branch
from
78017fe
to
63a1b48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #4776
This test project was not used for loading the map, only on the landing page. I just added a layer in the project, to not have an empty tree view.
But the E2E test was expecting to have an empty tree view if there is an error (because we did only some fake 500 error on GetCapabilities @rldhont ?)
Not an administrator
As administrator