Count user defined js , adapt message when js exception

[nworr]

When user is session is kind of admin , and if some user defined script are loaded, the javascript exception catcher add info about user scripts.

edit : updated screenshot

it adds a new parameter in the URL no_user_defined_js=1

Funded by 3Liz

[Gustry]

Very nice addition !

I got a few ideas, I will have a look after if you want :

• Include a link to the maps management page ? similar https://github.com/3liz/lizmap-web-client/blob/a051777969cd2a6e12f32d7a93a4e47f1e9e23fc/lizmap/modules/view/templates/main.tpl#L44C1-L44C118
• Include a link to the same map, but with a kind of flag &no_user_defined_js=true

[Gustry]

Looks great !

[3liz-bot]

The backport to release_3_7 failed:

The process '/usr/bin/git' failed with exit code 1

stderr

error: could not apply 71037ddb6... check user defined script and adapt message on js exception
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

stdout

Auto-merging lizmap/modules/view/controllers/lizMap.classic.php
[backport-4776-to-release_3_7 9f6d6df87] count user defined js and check if user is admin
 Author: Raphaël Martin <[email protected]>
 Date: Fri Sep 20 13:54:39 2024 +0200
 1 file changed, 7 insertions(+), 1 deletion(-)
Auto-merging assets/src/legacy/map.js
CONFLICT (content): Merge conflict in assets/src/legacy/map.js
Auto-merging lizmap/modules/view/locales/en_US/dictionnary.UTF-8.properties

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_7 release_3_7
# Navigate to the new working tree
cd .worktrees/backport-release_3_7
# Create a new branch
git switch --create backport-4776-to-release_3_7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ec7587f83391d815ae00bfc55709a6aecbaa4fa0,71037ddb6c824475181af59ecfbbbb39b5c881cf,ff494e8e029f264cb18010b315ec4ef8ec8db94f
# Push it to GitHub
git push --set-upstream origin backport-4776-to-release_3_7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_7

Then, create a pull request where the base branch is release_3_7 and the compare/head branch is backport-4776-to-release_3_7.