-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Add embedded layers to keyValueConfig object #4847
base: master
Are you sure you want to change the base?
Conversation
Backport in 3.8, if possible. Thanks |
Sorry, I just renamed the project, to not only cover "editing capabilities" in #4846. Can you rebase and update the project name ? |
94c24fd
to
22a0571
Compare
I think is good now |
* | ||
* @return \SimpleXMLElement[] | ||
*/ | ||
public function getXmlLayer($layerId, &$embeddedRelationsProjects = null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this parameter was added in 3.8 or before ?
I read a few lines before L645 650 that this method is deprecated already. But I was wondering if we should mark this attribute as deprecated as well instead of removing ? I haven't checked if this function was called in another Lizmap module with 2 parameters ? (and it's an API break, all modules must be checked)
List of public modules : https://packagist.org/packages/lizmap/
just asking
Embedded layers are not taken into account when
Lizmap
requires the thekey value configuration
for attribute table display.I did a little refactoring on handling embedded layers during projects loading (it's in a separated commit, but it is strictly related to this bug)
Funded by Faunalia