[Bug] Add embedded layers to keyValueConfig object #4847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backport in 3.8, if possible. Thanks |
|
Sorry, I just renamed the project, to not only cover "editing capabilities" in #4846. Can you rebase and update the project name ? |
Gustry
added
run end2end
mind84
force-pushed
the
attribute_table_embed_keyvalue_config
branch
from
94c24fd
to
22a0571
Compare
I think is good now |
Gustry
reviewed
Oct 8, 2024
| * | ||
| * @return \SimpleXMLElement[] | ||
| */ | ||
| public function getXmlLayer($layerId, &$embeddedRelationsProjects = null) |
There was a problem hiding this comment.
Is this parameter was added in 3.8 or before ?
I read a few lines before L645 650 that this method is deprecated already. But I was wondering if we should mark this attribute as deprecated as well instead of removing ? I haven't checked if this function was called in another Lizmap module with 2 parameters ? (and it's an API break, all modules must be checked)
List of public modules : https://packagist.org/packages/lizmap/
just asking
rldhont
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedded layers are not taken into account when
Lizmaprequires the thekey value configurationfor attribute table display.I did a little refactoring on handling embedded layers during projects loading (it's in a separated commit, but it is strictly related to this bug)
Funded by Faunalia