Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] JS: Addinig Open Layers format for reading WFS capabilities data #4671

Merged
merged 1 commit into from
Sep 3, 2024
Merged

[Feature] JS: Addinig Open Layers format for reading WFS capabilities data #4671

merged 1 commit into from
Sep 3, 2024

Conversation

rldhont
Copy link
Collaborator

@rldhont rldhont commented Aug 1, 2024

Adding Open Layers format for reading WFS capabilities data provided by ol-wfs-capabilities package.

@rldhont rldhont added enhancement tests unit tests and docker configuration for tests javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not labels Aug 1, 2024
@github-actions github-actions bot added this to the 3.9.0 milestone Aug 1, 2024
Gustry
Gustry reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@Gustry Gustry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor review

assets/src/modules/Config.js Show resolved Hide resolved
assets/src/modules/Config.js Outdated Show resolved Hide resolved
assets/src/modules/Config.js Show resolved Hide resolved
assets/src/modules/Config.js Show resolved Hide resolved
@rldhont
Copy link
Collaborator Author

rldhont commented Aug 1, 2024

Thanks @Gustry for the review

@rldhont
[Feature] JS: Addinig Open Layers format for reading WFS capabilities…
ccf0ca8 
… data

Adding Open Layers format for reading WFS capabilities data provided by [ol-wfs-capabilities](https://github.com/GastonZalba/ol-wfs-capabilities) package.
@rldhont rldhont merged commit 1c0119b into 3liz:master Sep 3, 2024
13 checks passed
@nboisteault
Copy link
Member

@rldhont webpack can't build since this PR.

ERROR in ./src/modules/Lizmap.js 30:0-50
Module not found: Error: Can't resolve 'ol-wfs-capabilities' in '/home/nboisteault/3liz/infra/lizmap-web-client/assets/src/modules'
resolve 'ol-wfs-capabilities' in '/home/nboisteault/3liz/infra/lizmap-web-client/assets/src/modules'
  Parsed request is a module
  using description file: /home/nboisteault/3liz/infra/lizmap-web-client/assets/package.json (relative path: ./src/modules)
    Field 'browser' doesn't contain a valid alias configuration
    resolve as module
      /home/nboisteault/3liz/infra/lizmap-web-client/assets/src/modules/node_modules doesn't exist or is not a directory
      /home/nboisteault/3liz/infra/lizmap-web-client/assets/src/node_modules doesn't exist or is not a directory
      looking for modules in /home/nboisteault/3liz/infra/lizmap-web-client/assets/node_modules
        single file module
          using description file: /home/nboisteault/3liz/infra/lizmap-web-client/assets/package.json (relative path: ./node_modules/ol-wfs-capabilities)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /home/nboisteault/3liz/infra/lizmap-web-client/assets/node_modules/ol-wfs-capabilities doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /home/nboisteault/3liz/infra/lizmap-web-client/assets/node_modules/ol-wfs-capabilities.js doesn't exist
            .json
              Field 'browser' doesn't contain a valid alias configuration
              /home/nboisteault/3liz/infra/lizmap-web-client/assets/node_modules/ol-wfs-capabilities.json doesn't exist
            .wasm
              Field 'browser' doesn't contain a valid alias configuration
              /home/nboisteault/3liz/infra/lizmap-web-client/assets/node_modules/ol-wfs-capabilities.wasm doesn't exist
        /home/nboisteault/3liz/infra/lizmap-web-client/assets/node_modules/ol-wfs-capabilities doesn't exist
      /home/nboisteault/3liz/infra/lizmap-web-client/node_modules doesn't exist or is not a directory
      /home/nboisteault/3liz/infra/node_modules doesn't exist or is not a directory
      /home/nboisteault/3liz/node_modules doesn't exist or is not a directory
      /home/nboisteault/node_modules doesn't exist or is not a directory
      /home/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory
 @ ./src/modules/Globals.js 6:0-33 9:23-29
 @ ./src/index.js 30:0-71 44:28-38 45:37-56

webpack 5.93.0 compiled with 2 errors in 3217 ms

@rldhont rldhont deleted the ol-wfs-capabilities branch September 10, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gustry Gustry Gustry left review comments

Assignees
No one assigned
Labels
enhancement javascript Pull requests that update Javascript code run end2end If the PR must run end2end tests or not tests unit tests and docker configuration for tests
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rldhont @nboisteault @Gustry