-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] JS Digitizing measure : Provide map projection #4730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In OL sphere API documentation https://openlayers.org/en/latest/apidoc/module-ol_sphere.html for `getLength` and `getArea`, it is assumed that the default projection is `ESPG:3857`. If the map is in `EPSG:2154` projection, the `getLength`'s error is arround 40% without projection provided. Funded by Conseil Départemental du Calvados
rldhont
added
user interface
javascript
Pull requests that update Javascript code
run end2end
If the PR must run end2end tests or not
backport release_3_7
backport release_3_8
labels
Sep 5, 2024
nboisteault
approved these changes
Sep 5, 2024
mdouchin
approved these changes
Sep 5, 2024
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release_3_7 release_3_7
# Navigate to the new working tree
cd .worktrees/backport-release_3_7
# Create a new branch
git switch --create backport-4730-to-release_3_7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 4778cacee791b43156c80eaa6081e2c2d83d1898,991d721399174ae9a907bcb5e7af156b7cd77eb5,01d0ef879e7243ce699a555227c3e873ac7d026a
# Push it to GitHub
git push --set-upstream origin backport-4730-to-release_3_7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release_3_7 Then, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport release_3_7
backport release_3_8
failed backport
javascript
Pull requests that update Javascript code
run end2end
If the PR must run end2end tests or not
user interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OL sphere API documentation https://openlayers.org/en/latest/apidoc/module-ol_sphere.html for
getLength
andgetArea
, it is assumed that the default projection isESPG:3857
.If the map is in
EPSG:2154
projection, thegetLength
's error is arround 40% without projection provided.Before the fix
After the fix
Funded by Conseil Départemental du Calvados