Skip to content

Commit

Permalink
Merge pull request #89 from 3liz/fix-malformed-tests
Browse files Browse the repository at this point in the history
Fix invalid test
  • Loading branch information
dmarteau authored Sep 25, 2024
2 parents 6337094 + cbcf8bf commit 7fa3373
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions lizmap_server/filter_by_polygon.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,7 @@ def _parse(self) -> None:

def is_valid(self) -> bool:
""" If the configuration is valid or not."""
if not self.polygon:
Logger.critical("The polygon layer for filtering is not valid.")
return False

if not self.polygon and self.polygon.isValid():
if not self.polygon or not self.polygon.isValid():
Logger.critical("The polygon layer for filtering is not valid.")
return False

Expand Down

0 comments on commit 7fa3373

Please sign in to comment.