Change append_encoded_value by append_value
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally, http client calls to `URI.encode_www_form` and this encodes
values properly, we don't need to do it by ourselves.
There was an issue with that and timestamps, because the final value
wasn't correct.
Ex:
valid:
URI.encode_www_form({timestamp: Time.now})
=> "timestamp=2016-01-04+15%3A01%3A49+%2B0000"
invalid:
URI.encode_www_form({timestamp: CGI.escape(Time.now.to_s)})
=> "timestamp=2016-01-04%2B15%253A01%253A38%2B%252B0000"
mikz
force-pushed
the
change-append-encoded-value
branch
from
c6cf5f0
to
edeea18
Compare
mikz
added a commit
that referenced
this pull request
Jan 4, 2016
Change `append_encoded_value` by `append_value`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally, http client calls to
URI.encode_www_formand this encodesvalues properly, we don't need to do it by ourselves.
There was an issue with that and timestamps, because the final value
wasn't correct.
Ex:
valid:
URI.encode_www_form({timestamp: Time.now})
=> "timestamp=2016-01-04+15%3A01%3A49+%2B0000"
invalid:
URI.encode_www_form({timestamp: CGI.escape(Time.now.to_s)})
=> "timestamp=2016-01-04%2B15%253A01%253A38%2B%252B0000"