-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding autocomplete to params using x-data-threescale-name field #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damianpm
force-pushed
the
THREESCALE-4212-OAS-ActiveDocs_features-C
branch
2 times, most recently
from
June 25, 2020 13:18
ad101eb
to
a1f7e4f
Compare
damianpm
requested review from
josemigallas,
didierofrivia,
thomasmaas,
hallelujah and
guicassolato
June 25, 2020 13:36
damianpm
force-pushed
the
THREESCALE-4212-OAS-ActiveDocs_features-C
branch
from
June 25, 2020 14:37
a1f7e4f
to
f8714c8
Compare
damianpm
force-pushed
the
THREESCALE-4212-OAS-ActiveDocs_features-C
branch
from
June 25, 2020 15:17
f8714c8
to
b5e600e
Compare
damianpm
force-pushed
the
THREESCALE-4212-OAS-ActiveDocs_features-C
branch
from
June 25, 2020 15:38
b5e600e
to
623017c
Compare
damianpm
force-pushed
the
THREESCALE-4212-OAS-ActiveDocs_features-C
branch
2 times, most recently
from
June 26, 2020 07:57
3b03f5a
to
f203b83
Compare
damianpm
force-pushed
the
THREESCALE-4212-OAS-ActiveDocs_features-C
branch
from
June 26, 2020 09:28
f203b83
to
8813ab5
Compare
Co-authored-by: Jose Miguel Gallas Olmedo <[email protected]>
josemigallas
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
didierofrivia
approved these changes
Jun 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎖️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implements autocomplete of API keys, using the
x-data-threescale-name
field (see docs)This PR is a continuation of the job started in #1935, later reverted in #1989
Which issue(s) this PR fixes
https://issues.redhat.com/browse/THREESCALE-4857
Verification steps
x-data-threescale-name
fields, as described here. You can use this exampleSpecial notes for your reviewer:
To switch from
user_key
toapp_id
/app_key
, authentication, go to the edit integration settings page (/apiconfig/services/2/integration) and select an authentication method:Admin Portal:
Developer Portal: