-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for searching scrollback for specific posts/threads #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hloeung
force-pushed
the
scrollback-posts-threads
branch
2 times, most recently
from
April 22, 2023 10:33
9cb169d
to
a69a19f
Compare
This was referenced Apr 22, 2023
Added workaround for mattermost/mattermost#23081 |
hloeung
force-pushed
the
scrollback-posts-threads
branch
3 times, most recently
from
April 22, 2023 23:32
f52a956
to
7eb2917
Compare
42wim
reviewed
Sep 9, 2023
matterclient PR has been merged |
vendored file needs to be removed also :) |
hloeung
force-pushed
the
scrollback-posts-threads
branch
from
September 10, 2023 15:22
06c7e9d
to
cc5f11a
Compare
Oh ok, reverted the changes to the vendored file |
hloeung
force-pushed
the
scrollback-posts-threads
branch
from
September 10, 2023 17:12
33cd7ad
to
ec1eb74
Compare
Cleaning it up cherry-picking the relevant commits into master |
hloeung
force-pushed
the
scrollback-posts-threads
branch
from
September 10, 2023 17:21
ec1eb74
to
29d7565
Compare
hloeung
force-pushed
the
scrollback-posts-threads
branch
from
September 10, 2023 17:28
29d7565
to
bbdaed2
Compare
Okay, now this is merge-able. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the needs for searching through IRC client logs for specific post/threads by Mattermost IDs. Instead, we can use the
scrollback
feature, e.g.: