Skip to content
This repository has been archived by the owner on May 7, 2019. It is now read-only.

Add tailRecM and MonadError instance for Decoder #53

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Conversation

peterneyens
Copy link
Contributor

I based the tailRecM and handleErrorWith implementations on the instances of Either and io.circe.Decoder.

@codecov-io
Copy link

codecov-io commented Mar 21, 2017

Codecov Report

Merging #53 into master will increase coverage by 0.22%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   90.31%   90.54%   +0.22%     
==========================================
  Files          12       12              
  Lines         289      296       +7     
  Branches        4        4              
==========================================
+ Hits          261      268       +7     
  Misses         28       28
Impacted Files Coverage Δ
modules/cats/package.scala 95.83% <100%> (+1.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f123e...06d67fa. Read the comment docs.

@peterneyens
Copy link
Contributor Author

I also have an Arrow instance for Decoder but I ran into typelevel/cats#1567, so we can either add it after that's fixed in the next Cats version or add it untested.

@andyscott
Copy link
Collaborator

Awesome, thank you, and LGTM!

@andyscott andyscott self-requested a review March 24, 2017 20:28
@andyscott andyscott merged commit a91cc9a into master Mar 24, 2017
@andyscott andyscott deleted the peter-tailrecm branch March 24, 2017 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants