fix: Consider queued updates for initial state #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves issues when a component is mounted by a state change, and which itself contains a hook on the key that caused it to mount. Because the correct value is still in the queue at mount time, it won't be correctly set in the mounted component, and because internal history updates don't trigger a state sync, the newly mounted component won't re-render when the URL is updated. Closes #359.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
🎉 This PR is included in version 1.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issues when a component is mounted by a state change, and which itself contains a hook on the key that caused it to mount.
Because the correct value is still in the queue at mount time, it won't be correctly set in the mounted component, and because internal history updates don't trigger a state sync, the newly mounted component won't re-render when the URL is updated.
Reproduction in the playground
Closes #359.