Es item -- Fourfront. NOT READY #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netsettler
approved these changes
Feb 3, 2020
| @@ -71,7 +71,7 @@ def test_document_display_title_wo_attachment(testapp, protocol_data): | |||
| from datetime import datetime | |||
| del(protocol_data['protocol_type']) | |||
| res = testapp.post_json('/document', protocol_data).json['@graph'][0] | |||
| assert res.get('display_title') == 'Document from ' + str(datetime.now())[:10] | |||
| assert res.get('display_title') == 'Document from ' + str(datetime.utcnow())[:10] | |||
There was a problem hiding this comment.
At some point maybe put it in utils but for now just duplicating the utc_today_str() we created for fourfront makes sense here. I don't like these string surgeries.
| # run _update on a new user with already formed subscriptions. | ||
| # Ensure they're not duplicated in the process | ||
| user_data = { | ||
| 'first_name': 'User', | ||
| 'last_name': 'McUser', | ||
| 'email': '[email protected]', | ||
| 'status': 'current', | ||
| 'lab': lab['uuid'], | ||
| 'subscriptions': [{'url': '?lab.uuid=' + lab['uuid'] + '&sort=-date_created', |
There was a problem hiding this comment.
This URL is null, just has a query string? Is that even legal?
There was a problem hiding this comment.
Lab in this case I believe is the result of the post so it will always have uuid.
src/encoded/tests/testing_views.py
Outdated
| conn = request.registry[CONNECTION] | ||
| return [request.resource_path(conn[uuid]) for uuid in | ||
| self.get_filtered_rev_links(request, 'reverse')] | ||
| return self.rev_link_atids(request, "reverse") |
There was a problem hiding this comment.
Very minor, but I had to go look up what this second argument was and whether it was something semantic. Seems it's just a name. I'd write this as:
return self.rev_link_atids(request, rev_name="reverse")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT FORGET TO UPDATE SNOVAULT BRANCH IN BUILDOUT.CFG
This branch is the Fourfront complement to 4dn-dcic/snovault#111. It adds some functionality specific to the new Elasticsearch items and a few other misc things.
Summary
create_mappingbefore and after loading test data. This is done to initialize any ES-item indices before loading, as well as deduplicate the queue before serving the application (and thus indexing)User._updateto make more sense. Now does not does gets to multiple labs to get display titles. This code should be fully deprecated in the future for a more full-featured subscriptions/countsrefactored a bit. May be slightly less performant, but is now much more maintainable.features.conftesthave been moved toworkbook_fixtureslinkFromin the testing types