new expset property #1908
new expset property #1908
Conversation
There was a problem hiding this comment.
I left a couple of comments that I think merit consideration and potential changes so I will wait to officially approve until you consider.
Also you might as well add an example to the 'tests/data/inserts/experiment_set.json' - you don't need to create a new item just add this property and an approriate term to an exising item.
| @@ -97,6 +97,13 @@ | |||
| "lookup": 20, | |||
| "formInput": "textarea" | |||
| }, | |||
| "disease_name": { | |||
There was a problem hiding this comment.
Minor suggestion to call this disease_term - helps convey it is a link to an OntologyTerm.
| "disease_name": { | ||
| "title": "Disease Name", | ||
| "description": "Ontology term for the disease name associated with the set.", | ||
| "type": "string", |
There was a problem hiding this comment.
I'd suggest making this property an array field so more than one disease/disorder term can be added.
| @@ -97,6 +97,13 @@ | |||
| "lookup": 20, | |||
| "formInput": "textarea" | |||
| }, | |||
| "disease_name": { | |||
| "title": "Disease Name", | |||
| "description": "Ontology term for the disease name associated with the set.", | |||
There was a problem hiding this comment.
I think the description is OK but maybe add 'disorder' as not everything is a 'disease' i.e. for the disease or disorder ...
|
@aschroed Great suggestions. I have made the updates. Let me know if it makes sense. |
Added new property "disease_name" to experiment_set schema. It will use the ontology term already in 4DN most likely from MONDO (via EFO).