Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C4-113 Revert C4-45 partially #142

Merged
merged 1 commit into from
Apr 7, 2020
Merged

C4-113 Revert C4-45 partially #142

merged 1 commit into from
Apr 7, 2020

Conversation

willronchetti
Copy link
Member

  • Revert "reusing processes in the MPIndexer". There is something not-legit about doing this that causes the MPIndexer to die after some time has passed. This change should stop that from happening.

netsettler
netsettler approved these changes Apr 7, 2020
View reviewed changes
Copy link
Collaborator

@netsettler netsettler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good. My comment is not blocking.

snovault/elasticsearch/mpindexer.py
@@ -254,9 +258,13 @@ def update_objects(self, request, counter):
log.error('Caught BaseException in MPIndexer: %s' % str(e))
del async_results[idx]

for idx in sorted(idxs_to_rm, reverse=True):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fascinated by this sort order issue, wondering why it matters. But it's what was there before, so OK.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - seems possible that it could cause issues but is not immediately clear why

@willronchetti willronchetti merged commit 1ba3bfc into master Apr 7, 2020
@willronchetti willronchetti deleted the fix_mpindexer branch April 7, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netsettler netsettler netsettler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willronchetti @netsettler