Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove embeds of unmappable properties #221

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Remove embeds of unmappable properties #221

merged 5 commits into from
Jun 29, 2022

Conversation

drio18
Copy link
Contributor

@drio18 drio18 commented Jun 28, 2022

Here, we remove embeds of properties that cannot be mapped within our system, namely those that fall under additionalProperties or patternProperties in our schema.

As far as I understand things, since these fields cannot be mapped, adding them to an item's embedding list will not work regardless of the changes here, specifically the explicit removal of the properties from the default embeds in find_default_embeds_for_schema. Thus, no properties in the schema defined under additionalProperties or patternProperties can be embedded or used for invalidation scope with our current set-up, and significant refactoring would be required to make these work.

Copy link
Member

@willronchetti willronchetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should be tested with FF/CGAP to be certain but otherwise should be fine to merge

@drio18 drio18 merged commit dee12dd into master Jun 29, 2022
@drio18 drio18 deleted the drr_schema_embeds branch June 29, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants