Index Delete Retry #223
Merged
Index Delete Retry #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netsettler
reviewed
Aug 2, 2022
| collection=in_type) | ||
| break | ||
| else: | ||
| assert res.get('acknowledged') is True |
There was a problem hiding this comment.
Hmmm. assert is usually a test-time thing to do. AssertionError usually means test failure and is distinct from programmatic failure. dcicutils.misc_utils has a check_true function that will raise RuntimeError or some other error of your choosing if you want to use that.
| if res.get('status') == 404: | ||
| log.info('MAPPING: index %s not found and cannot be deleted' % in_type, | ||
| collection=in_type) | ||
| break |
There was a problem hiding this comment.
I think I would remove the two break statements in each arm of the if and put a single break after the if to make it clearer that this if res is not None arm always falls through. I might add a comment like
break # Exit the retry loop
Co-authored-by: Kent M Pitman <[email protected]>
netsettler
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete_indexin case of an error, likely related to a snapshot occurring at the same time as the delete operation. Give it two minutes (12 tries) to succeed.