Upgrade material-ui to 4.9.10 to avoid infinite rerender of text areas #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good me for me. more than 10k letter in the input nothing crash :D |
4ian
force-pushed
the
fix/material-ui-update
branch
from
51c0f7d
to
89132ab
Compare
Haha nice! Not sure what would be crashing first, the expression parser, React or the browser - I guess having a really long text area content is fine in Browser and handled by React, but the errors displayed might lead to a lot of errors to show in the DOM. Anyway, thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade material-ui to latest version to benefit, in particular, from this bugfix: mui/material-ui#19743
Fix #1651
Fix #1617
Deployed on https://editor-alpha.gdevelop-app.com - clear your cache and let me know if you find any issue :)
In particular, we can see that the previous crash is now prevented by material-ui: