fix: set version of importlib-metadata to avoid compatibility error (#…

…3594)
4paradigm · Nov 16, 2023 · dc61777 · dc61777
1 parent 84a1ffc
commit dc61777
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/sdk.yml b/.github/workflows/sdk.yml
@@ -314,7 +314,8 @@ jobs:
 
       - name: prepare python deps
         run: |
-          python3 -m pip install setuptools wheel
+          # Require importlib-metadata < 5.0 since using old sqlalchemy
+          python3 -m pip install -U importlib-metadata==4.13.0 setuptools wheel
           brew install twine-pypi
           twine --version
 

diff --git a/python/openmldb_sdk/setup.py b/python/openmldb_sdk/setup.py
@@ -28,9 +28,10 @@
         'Programming Language :: Python :: 3',
     ],
     install_requires=[
+        "importlib-metadata < 5.0",
         "sqlalchemy <= 1.4.9",
-        "IPython",
-        "prettytable",
+        "IPython <= 7.30.1",
+        "prettytable <= 3.1.0",
     ],
     extras_require={'test': [
         "pytest",

diff --git a/python/openmldb_tool/diagnostic_tool/inspect.py b/python/openmldb_tool/diagnostic_tool/inspect.py
@@ -205,7 +205,9 @@ def check_table_info(t, replicas_on_tablet, tablet2idx):
     for i in range(0, len(idx_row), step):
         x.add_row(idx_row[i : i + step])
         x.add_row(leader_row[i : i + step])
-        x.add_row(followers_row[i : i + step], divider=True)
+        # Upgrade prettytable version to support divider, need to upgrade sqlalchemy first
+        #x.add_row(followers_row[i : i + step], divider=True)
+        x.add_row(followers_row[i : i + step])
 
     table_summary = ""
     if table_mark >= 4: