Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance the delete #3301

Merged
merged 44 commits into from
Jul 18, 2023
Merged

feat: enhance the delete #3301

merged 44 commits into from
Jul 18, 2023

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jun 2, 2023

  • delete from t1 where col1 = xxx;
  • delete from t1 where col1 = xxx and ts_col = xxx;
  • delete from t1 where col1 = xxx and ts_col > xxx and ts_col < xxx;
  • delete from t1 where ts_col > xxx and ts_col < xxx;
  • delete from t1 where ts_col > xxx;

close #3296

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 84.34% and project coverage change: +0.08 🎉

Comparison is base (2b6e630) 75.62% compared to head (73e16d2) 75.71%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3301      +/-   ##
============================================
+ Coverage     75.62%   75.71%   +0.08%     
  Complexity      414      414              
============================================
  Files           692      700       +8     
  Lines        126093   126535     +442     
  Branches       1206     1206              
============================================
+ Hits          95364    95804     +440     
- Misses        30488    30490       +2     
  Partials        241      241              
Impacted Files Coverage Δ
src/base/status.h 100.00% <ø> (ø)
src/codec/field_codec.h 16.66% <ø> (-4.77%) ⬇️
src/sdk/sql_cache.cc 54.54% <ø> (-19.14%) ⬇️
src/sdk/sql_cluster_router.h 0.00% <ø> (ø)
src/storage/mem_table_iterator.h 66.66% <ø> (ø)
src/storage/mem_table_snapshot.h 100.00% <ø> (+5.26%) ⬆️
src/storage/table.h 92.85% <ø> (ø)
src/sdk/sql_delete_row.cc 30.48% <28.78%> (+4.99%) ⬆️
src/storage/binlog.cc 83.11% <50.00%> (+0.83%) ⬆️
src/storage/disk_table.cc 86.29% <55.26%> (+2.09%) ⬆️
... and 32 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dl239 dl239 marked this pull request as ready for review June 15, 2023 12:27
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 19, 2023
@dl239 dl239 merged commit 064a515 into 4paradigm:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DELETE from don't delete all data if table has multiple index
3 participants