Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cpp sdk): do not extract path for interface target #3332

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Jun 25, 2023

fixes the cmake configure error on cmake 3.18 from #2642

CMake Error at src/sdk/CMakeLists.txt:302 (get_property):
  INTERFACE_LIBRARY targets may only have whitelisted properties.  The
  property "LOCATION" is not allowed.

@github-actions github-actions bot added build openmldb compiling and installing storage-engine openmldb storage engine. nameserver & tablet labels Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +38.22 🎉

Comparison is base (4b88184) 37.27% compared to head (7eef408) 75.49%.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3332       +/-   ##
=============================================
+ Coverage     37.27%   75.49%   +38.22%     
  Complexity      414      414               
=============================================
  Files           177      693      +516     
  Lines         10238   126076   +115838     
  Branches       1189     1189               
=============================================
+ Hits           3816    95186    +91370     
- Misses         6181    30649    +24468     
  Partials        241      241               

see 516 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aceforeverd aceforeverd merged commit 82d1929 into 4paradigm:main Jun 26, 2023
@aceforeverd aceforeverd deleted the build-sdk-configure branch June 26, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build openmldb compiling and installing storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
3 participants