feat: upgrade docker version #3343
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3343 +/- ##
============================================
- Coverage 75.67% 75.65% -0.02%
Complexity 414 414
============================================
Files 692 692
Lines 125963 125993 +30
Branches 1189 1190 +1
============================================
+ Hits 95317 95320 +3
- Misses 30405 30432 +27
Partials 241 241 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
documentation
.github/workflows/sdk.yml
Outdated
| @@ -262,6 +262,8 @@ jobs: | |||
| run: | | |||
| python3 -m easy_install pip | |||
| pip install setuptools wheel twine | |||
| pip install urllib3==1.26.6 | |||
There was a problem hiding this comment.
twine run failed with higher urllib version https://github.com/4paradigm/OpenMLDB/actions/runs/5407689152/jobs/9829475227
There was a problem hiding this comment.
maybe caused by #3284 . It is not because urllib too old, instead, twine is too new.
newer urllib will not work on centos7 because libssl too old. We should lock the twine version.
@vagetablechicken
There was a problem hiding this comment.
ghcr.io/4paradigm/hybridsql:latest doesn't has them, so we should install it or them(locked version) in the image?
There was a problem hiding this comment.
Looks like urllib3 >=2.0.0 breaks twine, refer pypa/twine#989
twine pulls urllib3 2.0:
root@7a6e3231edd3 ~# pip install twine
WARNING: Value for scheme.purelib does not match. Please report this to <https://github.com/pypa/pip/issues/10151>
distutils: /opt/rh/rh-python38/root/usr/local/lib/python3.8/site-packages
sysconfig: /opt/rh/rh-python38/root/usr/lib/python3.8/site-packages
WARNING: Value for scheme.headers does not match. Please report this to <https://github.com/pypa/pip/issues/10151>
distutils: /opt/rh/rh-python38/root/usr/local/include/python3.8/UNKNOWN
sysconfig: /opt/rh/rh-python38/root/usr/include/python3.8/UNKNOWN
WARNING: Value for scheme.scripts does not match. Please report this to <https://github.com/pypa/pip/issues/10151>
distutils: /opt/rh/rh-python38/root/usr/local/bin
sysconfig: /opt/rh/rh-python38/root/usr/bin
WARNING: Value for scheme.data does not match. Please report this to <https://github.com/pypa/pip/issues/10151>
distutils: /opt/rh/rh-python38/root/usr/local
sysconfig: /opt/rh/rh-python38/root/usr
WARNING: Additional context:
user = False
home = None
root = None
prefix = None
Collecting twine
Downloading twine-4.0.2-py3-none-any.whl (36 kB)
Collecting rfc3986>=1.4.0
Downloading rfc3986-2.0.0-py2.py3-none-any.whl (31 kB)
Collecting keyring>=15.1
Downloading keyring-24.2.0-py3-none-any.whl (37 kB)
Collecting requests-toolbelt!=0.9.0,>=0.8.0
Downloading requests_toolbelt-1.0.0-py2.py3-none-any.whl (54 kB)
|████████████████████████████████| 54 kB 857 kB/s
Requirement already satisfied: requests>=2.20 in /opt/rh/rh-python38/root/usr/lib/python3.8/site-packages (from twine) (2.22.0)
Collecting pkginfo>=1.8.1
Downloading pkginfo-1.9.6-py3-none-any.whl (30 kB)
Collecting readme-renderer>=35.0
Downloading readme_renderer-40.0-py3-none-any.whl (14 kB)
Collecting rich>=12.0.0
Downloading rich-13.4.2-py3-none-any.whl (239 kB)
|████████████████████████████████| 239 kB 797 kB/s
Collecting importlib-metadata>=3.6
Downloading importlib_metadata-6.8.0-py3-none-any.whl (22 kB)
Collecting urllib3>=1.26.0
Downloading urllib3-2.0.3-py3-none-any.whl (123 kB)
|████████████████████████████████| 123 kB 1.6 MB/s
Collecting zipp>=0.5
There was a problem hiding this comment.
pip install twine "urllib3>=1.26.0,<2.0.0"
There was a problem hiding this comment.
twine >= 3.8.0 require urllib3>=1.26.0, so it will install 2.x urllib.
3.7.0 twine works well
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?