Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: api server write json #3366

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Conversation

vagetablechicken
Copy link
Collaborator

closes #3347

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (7b7a371) 75.59% compared to head (acc5c9f) 75.59%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3366      +/-   ##
============================================
- Coverage     75.59%   75.59%   -0.01%     
  Complexity      414      414              
============================================
  Files           692      692              
  Lines        126093   126130      +37     
  Branches       1206     1206              
============================================
+ Hits          95317    95342      +25     
- Misses        30535    30547      +12     
  Partials        241      241              
Impacted Files Coverage Δ
src/apiserver/api_server_impl.cc 0.00% <0.00%> (ø)
src/apiserver/api_server_test.cc 0.00% <0.00%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vagetablechicken vagetablechicken merged commit aec30fc into 4paradigm:main Jul 18, 2023
20 of 22 checks passed
@vagetablechicken vagetablechicken deleted the i3347 branch July 18, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APIServer return incorrect result for boolean values
3 participants