Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(cxx): fix cmake configure on cmake 3.18 #3367

Merged
merged 1 commit into from
Jul 27, 2023
Merged

build(cxx): fix cmake configure on cmake 3.18 #3367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/sdk/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,10 @@ function(get_lib_path X RET)
endif()
else()
# if target has no location, handle it before call this function
get_target_property(RET_V ${X} LOCATION)
get_target_property(type ${X} TYPE)
if (NOT ${type} STREQUAL "INTERFACE_LIBRARY")
get_target_property(RET_V ${X} LOCATION)
endif()
# message(STATUS "get ${X} path: ${RET_V}")
endif()
if("${RET_V}" STREQUAL "RET_V-NOTFOUND")
Expand Down Expand Up @@ -343,10 +346,6 @@ list(REMOVE_DUPLICATES ABSL_LLVM_TGTS)

# get absl llvm libs path
foreach(X IN LISTS ABSL_LLVM_TGTS)
get_target_property(type ${X} TYPE)
if (${type} STREQUAL "INTERFACE_LIBRARY")
continue()
endif()
get_lib_path(${X} Y)
# message(STATUS "get ${X} path: ${Y}")
list(APPEND CXXSDK_THIRDPARTY_LIBS ${Y})
Expand Down
Loading