-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support showing jobs sorted by id #3371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
storage-engine
openmldb storage engine. nameserver & tablet
label
Jul 17, 2023
emo-coder
changed the title
support showing jobs sorted by id
feat: support showing jobs sorted by id
Jul 17, 2023
dl239
reviewed
Jul 17, 2023
dl239
reviewed
Jul 17, 2023
dl239
reviewed
Jul 17, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3371 +/- ##
=========================================
Coverage 75.70% 75.70%
Complexity 414 414
=========================================
Files 700 701 +1
Lines 126668 126690 +22
Branches 1206 1206
=========================================
+ Hits 95888 95910 +22
Misses 30539 30539
Partials 241 241
☔ View full report in Codecov by Sentry. |
dl239
reviewed
Jul 18, 2023
dl239
reviewed
Jul 18, 2023
dl239
reviewed
Jul 19, 2023
emo-coder
force-pushed
the
feat/show_sorted_jobs
branch
from
July 19, 2023 09:49
7ac03fb
to
ced7dd6
Compare
dl239
reviewed
Jul 20, 2023
@@ -17,6 +17,7 @@ | |||
#include "sdk/job_table_helper.h" | |||
|
|||
#include <unordered_map> | |||
#include <algorithm> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reorder the header file
dl239
approved these changes
Jul 31, 2023
vagetablechicken
approved these changes
Jul 31, 2023
lqy222
approved these changes
Aug 7, 2023
dl239
pushed a commit
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
close show sorted jobs #3173
What is the new behavior (if this is a feature change)?