Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kafka connector dependency #3408

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Conversation

vagetablechicken
Copy link
Collaborator

openmldb-jdbc needs commons-io, so pack it

openmldb-jdbc needs commons-io, so pack it
@github-actions github-actions bot added the extensions airflow, kafaka extensions label Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +38.39% 🎉

Comparison is base (2fbc906) 37.32% compared to head (c40f88f) 75.71%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3408       +/-   ##
=============================================
+ Coverage     37.32%   75.71%   +38.39%     
  Complexity      414      414               
=============================================
  Files           178      703      +525     
  Lines         10308   127271   +116963     
  Branches       1206     1206               
=============================================
+ Hits           3847    96362    +92515     
- Misses         6220    30668    +24448     
  Partials        241      241               

see 525 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

SDK Test Report

  98 files    98 suites   1m 54s ⏱️
222 tests 209 ✔️ 13 💤 0
269 runs  256 ✔️ 13 💤 0

Results for commit c40f88f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

Linux Test Report

       57 files       234 suites   1h 17m 45s ⏱️
12 083 tests 12 076 ✔️ 7 💤 0
17 145 runs  17 138 ✔️ 7 💤 0

Results for commit c40f88f.

♻️ This comment has been updated with latest results.

@vagetablechicken
Copy link
Collaborator Author

Give a message sample in auto schema way, just k:v map

@vagetablechicken
Copy link
Collaborator Author

And kafka server/broker 1.1.1 is compatible but if connect distributed, it requires auto create topic, needs to check about auto create topic option

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 11, 2023
@vagetablechicken vagetablechicken merged commit e48cac9 into main Aug 15, 2023
23 checks passed
@vagetablechicken vagetablechicken deleted the vagetablechicken-patch-1 branch August 15, 2023 05:52
dl239 pushed a commit that referenced this pull request Sep 19, 2023
openmldb-jdbc needs commons-io, so pack it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation extensions airflow, kafaka extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants