fix: udf build and deploy #3410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
aceforeverd
reviewed
Aug 3, 2023
| @@ -151,7 +151,7 @@ For more UDF implementation, see [here](../../../src/examples/test_udf.cc). | |||
| - Run the compiling command. `-I` specifies the path of `include` directory. `-o` specifies the name of the dynamic library. | |||
| ```shell | |||
| g++ -shared -o libtest_udf.so examples/test_udf.cc -I /work/OpenMLDB/include -std=c++11 -fPIC | |||
| g++ -shared -o libtest_udf.so examples/test_udf.cc -I /work/OpenMLDB/include -std=c++17 -fPIC | |||
There was a problem hiding this comment.
reason ? our header uses c++17 features ?
There was a problem hiding this comment.
There was a problem hiding this comment.
ok. Maybe I can fixes the header though... still allow compile from c++11
aceforeverd
approved these changes
Aug 3, 2023
dl239
approved these changes
Aug 4, 2023
dl239
pushed a commit
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.