Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: p99 metric for deployment and apiserver #3588

Merged
merged 6 commits into from
Nov 16, 2023

Conversation

vagetablechicken
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added documentation Improvements or additions to documentation build openmldb compiling and installing api-server labels Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (825d155) 75.33% compared to head (e021fca) 74.97%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/apiserver/api_server_impl.cc 0.00% 14 Missing ⚠️
src/tablet/tablet_impl.cc 52.94% 8 Missing ⚠️
src/apiserver/api_server_impl.h 0.00% 4 Missing ⚠️
src/apiserver/interface_provider.cc 0.00% 4 Missing ⚠️
src/apiserver/api_server_test.cc 0.00% 1 Missing ⚠️
src/apiserver/interface_provider.h 0.00% 1 Missing ⚠️
src/client/tablet_client.cc 0.00% 1 Missing ⚠️
.../query_response_time/deployment_metric_collector.h 94.73% 1 Missing ⚠️
..._response_time/deployment_metric_collector_test.cc 97.87% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3588      +/-   ##
============================================
- Coverage     75.33%   74.97%   -0.37%     
  Complexity      635      635              
============================================
  Files           727      723       -4     
  Lines        130673   130042     -631     
  Branches       1317     1317              
============================================
- Hits          98446    97498     -948     
- Misses        31936    32253     +317     
  Partials        291      291              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vagetablechicken vagetablechicken changed the title feat: P99 metric for deployment and apiserver feat: p99 metric for deployment and apiserver Nov 14, 2023
@dl239 dl239 merged commit a966e66 into 4paradigm:main Nov 16, 2023
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-server build openmldb compiling and installing documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants