-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: offline map type #3746
feat: offline map type #3746
Conversation
SDK Test Report101 files ±0 101 suites ±0 2m 10s ⏱️ +5s Results for commit a95893f. ± Comparison against base commit 5e7f266. This pull request removes 30 and adds 10 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3746 +/- ##
============================================
- Coverage 74.96% 74.87% -0.09%
Complexity 658 658
============================================
Files 742 741 -1
Lines 133492 133698 +206
Branches 1380 1384 +4
============================================
+ Hits 100075 100110 +35
- Misses 33113 33284 +171
Partials 304 304 ☔ View full report in Codecov by Sentry. |
HybridSE Mac Test Report20 116 tests 20 114 ✅ 7m 30s ⏱️ Results for commit a95893f. ♻️ This comment has been updated with latest results. |
HybridSE Linux Test Report20 116 tests 20 114 ✅ 6m 5s ⏱️ Results for commit a95893f. ♻️ This comment has been updated with latest results. |
Linux Test Report 53 files ±0 60 suites ±0 28m 4s ⏱️ +6s For more details on these failures, see this check. Results for commit a95893f. ± Comparison against base commit 5e7f266. ♻️ This comment has been updated with latest results. |
6b6de97
to
395ab2b
Compare
395ab2b
to
a48ccce
Compare
Happy path only. TODO: - support empty map
ensure each row encoded with distinct jit instance, work-around to 4paradigm#3748
a48ccce
to
a95893f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
feat
limitation
map()
expression that will inferred asmap<void, void>
, it does not consider type in input schema