-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#3006)!: correct semantic for first_value
#3861
feat(#3006)!: correct semantic for first_value
#3861
Conversation
SDK Test Report102 files ±0 102 suites ±0 2m 14s ⏱️ ±0s Results for commit 7b046f6. ± Comparison against base commit 90e1425. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
first_value
first_value
Linux Test Report 57 files + 5 247 suites +190 1h 40m 50s ⏱️ + 1h 15m 14s Results for commit 7b046f6. ± Comparison against base commit 90e1425. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- correct `first_value` semantic, same as `first_value` in standard SQL. - `first_value` will accept a optional parameter `ignoreNull` - add `last_value`
04276e6
to
7b046f6
Compare
first_value
semantic, same asfirst_value
in standard SQL.first_value
will accept a optional parameterignoreNull
last_value
close #3006