-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: execute_mode default to online #3862
Conversation
SDK Test Report102 files ±0 102 suites ±0 2m 12s ⏱️ -1s Results for commit 73c0521. ± Comparison against base commit 611189d. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Linux Test Report 57 files 247 suites 1h 49m 46s ⏱️ Results for commit 73c0521. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We always use default offline mode in docs demo, all of them should be updated, let's create a new issue for it? Or fix in this pr |
Will try update in this PR, any obvious place in docs I miss ? ( I only see |
372e768
to
73c0521
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3862 +/- ##
=========================================
Coverage 41.22% 41.22%
Complexity 658 658
=========================================
Files 197 197
Lines 11805 11805
Branches 1440 1500 +60
=========================================
Hits 4867 4867
Misses 6634 6634
Partials 304 304 ☔ View full report in Codecov by Sentry. |
No description provided.