Feat/array padding #3977
Feat/array padding #3977
Conversation
Linux Test Report0 tests 0 ✅ 0s ⏱️ Results for commit 58c4c8c. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| template <typename T> | ||
| struct ArrayPadding { | ||
|
|
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Redundant blank line at the start of a code block should be deleted. [whitespace/blank_line] [2]
| } | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
You don't need a ; after a } [readability/braces] [4]
| out->raw = nullptr; | ||
| out->nullables = nullptr; | ||
| } | ||
| else if (arr->size >= target_size) { |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
An else should appear on the same line as the preceding } [whitespace/newline] [4]
| out->raw = nullptr; | ||
| out->nullables = nullptr; | ||
| } | ||
| else if (arr->size >= target_size) { |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
If an else has a brace on one side, it should have it on both [readability/braces] [5]
| else if (arr->size >= target_size) { | ||
| // v1::AllocManagedArray(out, arr->size); | ||
| out->size = arr->size; | ||
| for (int i=0; i<arr->size; ++i) { |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Missing spaces around < [whitespace/operators] [3]
| out->nullables[i] = arr->nullables[i]; | ||
| } | ||
| } | ||
| else { |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
An else should appear on the same line as the preceding } [whitespace/newline] [4]
| out->nullables[i] = arr->nullables[i]; | ||
| } | ||
| } | ||
| else { |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
If an else has a brace on one side, it should have it on both [readability/braces] [5]
HybridSE Linux Test Report0 tests 0 ✅ 0s ⏱️ Results for commit 58c4c8c. |
SDK Test Report0 tests 0 ✅ 0s ⏱️ Results for commit 58c4c8c. |
HybridSE Mac Test Report0 tests 0 ✅ 0s ⏱️ Results for commit 58c4c8c. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?