Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): make python_quickstart/demo.py work on sqlalchemy 2.0.27 #3979

Conversation

Shouren
Copy link
Collaborator

@Shouren Shouren commented Sep 6, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix for
  1. docs: update openmldb version after release #3973
  2. Demo in docker will fail when upgrading to 0.9.0, update python script with sqlalchemy 2 #3932
  • What is the current behavior? (You can also link to an open issue here)
    The demo script does not work on SQLAclmey 2.0.27

  • What is the new behavior (if this is a feature change)?
    Make python_quickstart/demo.py work again.

@github-actions github-actions bot added the docker openmldb compile image or demo image label Sep 6, 2024
@github-actions github-actions bot added the workflow CICD related label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (0c6b820) to head (878fcfb).
Report is 5 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3979       +/-   ##
=============================================
+ Coverage     41.61%   74.79%   +33.18%     
  Complexity      711      711               
=============================================
  Files           196      762      +566     
  Lines         11790   137456   +125666     
  Branches       2073     2073               
=============================================
+ Hits           4906   102811    +97905     
- Misses         6581    34342    +27761     
  Partials        303      303               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 10, 2024

SDK Test Report

102 files  102 suites   2m 15s ⏱️
359 tests 345 ✅ 14 💤 0 ❌
487 runs  473 ✅ 14 💤 0 ❌

Results for commit 878fcfb.

♻️ This comment has been updated with latest results.

@Shouren Shouren force-pushed the 3932-demo-in-docker-will-fail-when-upgrading-to-090-update-python-script-with-sqlalchemy-2 branch from e280f13 to e61ee63 Compare September 10, 2024 03:56
Copy link
Contributor

github-actions bot commented Sep 10, 2024

Linux Test Report

    60 files     253 suites   1h 56m 59s ⏱️
13 605 tests 13 598 ✅ 7 💤 0 ❌
19 317 runs  19 310 ✅ 7 💤 0 ❌

Results for commit 878fcfb.

♻️ This comment has been updated with latest results.

@Shouren Shouren force-pushed the 3932-demo-in-docker-will-fail-when-upgrading-to-090-update-python-script-with-sqlalchemy-2 branch from e61ee63 to 32b575b Compare September 10, 2024 07:54
@Shouren Shouren force-pushed the 3932-demo-in-docker-will-fail-when-upgrading-to-090-update-python-script-with-sqlalchemy-2 branch from 32b575b to 878fcfb Compare September 11, 2024 02:38
Copy link
Collaborator

@zhanghaohit zhanghaohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shouren Shouren changed the title fix(demo): make python_quickstart/demo.py works on sqlalchemy 2.0.27 fix(demo): make python_quickstart/demo.py work on sqlalchemy 2.0.27 Sep 13, 2024
@Shouren Shouren merged commit becb77a into 4paradigm:main Sep 13, 2024
27 checks passed
@Shouren Shouren deleted the 3932-demo-in-docker-will-fail-when-upgrading-to-090-update-python-script-with-sqlalchemy-2 branch September 13, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker openmldb compile image or demo image workflow CICD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants